Gleiphir2769 commented on code in PR #805:
URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983281714


##########
pulsar/consumer_impl.go:
##########
@@ -91,6 +90,15 @@ func newConsumer(client *client, options ConsumerOptions) 
(Consumer, error) {
                }
        }
 
+       if options.MaxPendingChunkedMessage == 0 {
+               options.MaxPendingChunkedMessage = 100
+       }
+
+       // the minimum timer interval is 100ms

Review Comment:
   Sorry, this minimum value is original for `timewheel`. Given that 
`timewheel` has been removed, this minimum value is unneccessary.
   I will remove it.



##########
pulsar/consumer_impl.go:
##########
@@ -91,6 +90,15 @@ func newConsumer(client *client, options ConsumerOptions) 
(Consumer, error) {
                }
        }
 
+       if options.MaxPendingChunkedMessage == 0 {
+               options.MaxPendingChunkedMessage = 100
+       }
+
+       // the minimum timer interval is 100ms

Review Comment:
   Sorry, this minimum value is original for `timewheel`. Given that 
`timewheel` has been removed, this minimum value is unneccessary.
   
   I will remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to