BewareMyPower commented on PR #3:
URL:
https://github.com/apache/pulsar-client-python/pull/3#issuecomment-1263062569
Hi @merlimat, here are my points for some of your concerns.
For the most important issue (IMO) you've mentioned
> We must not use a random version from C++ client main branch.
The main branch is not guaranteed to be stable. We should only depend the
stable version of C++ client for formal releases. For example, git submodule
can specify a tag of a formal C++ client release. When we release a Python
client, we can specify the tag like
```
[submodule "pulsar-client-cpp"]
path = pulsar-client-cpp
url = https://github.com/apache/pulsar-client-cpp.git
tag = v3.0.0-pre-release-1
```
The main branch should also relies on a tag. However, there is no tag in the
new created pulsar-client-cpp repo. Should we create one and rely on it? Or I
think we can reset to a specific commit in the script here.
----
> When we're building a source tar.gz we would have to include C++ code
> The Python wrapper shouldn't depend on any internal code from the C++
library, just the public API
I agree. Just want to remove the dependency in another PR. I will do that in
this PR soon.
> When building Python client, we shouldn't be building the C++ client lib.
Instead we should just fetch the binaries that are already available (eg: RPM,
Deb, APK, etc.. )
However, it makes the release or Python client slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
