merlimat commented on code in PR #1:
URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984709443
##########
CMakeLists.txt:
##########
@@ -86,18 +179,18 @@ if (APPLE)
endif ()
endif()
-message(STATUS "Using Boost Python libs: ${PYTHON_WRAPPER_LIBS}")
-
if (NOT PYTHON_WRAPPER_LIBS)
MESSAGE(FATAL_ERROR "Could not find Boost Python library")
endif ()
+message(STATUS "All libraries: ${PYTHON_WRAPPER_LIBS}")
+
if (APPLE)
set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS
"${CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS} -undefined dynamic_lookup")
- target_link_libraries(_pulsar -Wl,-all_load pulsarStatic
${PYTHON_WRAPPER_LIBS} ${COMMON_LIBS} ${ICU_LIBS})
+ target_link_libraries(_pulsar -Wl,-all_load ${PYTHON_WRAPPER_LIBS}
${COMMON_LIBS} ${ICU_LIBS})
else ()
if (NOT MSVC)
set (CMAKE_SHARED_LINKER_FLAGS " -static-libgcc -static-libstdc++")
endif()
- target_link_libraries(_pulsar pulsarStatic ${PYTHON_WRAPPER_LIBS}
${COMMON_LIBS})
+ target_link_libraries(_pulsar ${PYTHON_WRAPPER_LIBS} ${COMMON_LIBS})
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
