merlimat commented on code in PR #19:
URL: https://github.com/apache/pulsar-client-cpp/pull/19#discussion_r990146354
##########
.github/workflows/ci-build-binary-artifacts.yaml:
##########
@@ -43,8 +41,20 @@ jobs:
- name: Package Pulsar source
run: build-support/generate-source-archive.sh
+ - uses: docker/setup-buildx-action@v2
+ - run: build-support/copy-deps-versionfile.sh
+
+ - name: Build dependencies Docker image
+ uses: docker/build-push-action@v3
+ with:
+ context: ./pkg/deb
+ tags: ${{ env.TEST_TAG }}
Review Comment:
That’s a good point and a good catch. I thought it was auto assigned some
unique tag, though it just ends up being an empty tag, so it goes using the
default image, which is already on dockerhub. I’ll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
