dave2wave commented on PR #17956: URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1272220349
> We should add a check that rejects the invalid configuration There is a checkArgument if we set the policy through an admin call. Are you suggesting that we also test validity when a policy is created? This can be incomplete since the full check includes knowing the broker configuration to handle the currently allowed maximums for the ensemble size. I don't think testing without the max part is wrong, I'm just looking for clarification. In any case I think that check is a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
