codelipenghui commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1272258331
> For unreadable entries, an entry with the skpped flag will be created. When pushing messages, the entries with the skipped flag as true will be filtered out, and then these messages will be acked I see. It looks like the read operation will return some fake entries to the caller. Then the caller ack the entries according to the skip flag introduced in the `EntryImpl`. What is the difference between ack the entries directly when we complete the read operation by `checkReadCompletion`? In this way, we don't need to introduce a new concept to the `EntryImpl`, and the caller also has no responsibility to help managed cursor handle internal ack state maintenance issues. BTW, the Pulsar SQL also uses the cursor API to read data from bookies. If we add `skipped` field to the `EntryImpl`, the Pulsar SQL might also need to handle this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
