tisonkun commented on code in PR #17382:
URL: https://github.com/apache/pulsar/pull/17382#discussion_r990870636
##########
build/run_unit_group.sh:
##########
@@ -129,7 +129,7 @@ function test_group_proxy() {
function test_group_other() {
mvn_test --clean --install \
- -pl
'!org.apache.pulsar:distribution,!org.apache.pulsar:pulsar-offloader-distribution,!org.apache.pulsar:pulsar-server-distribution,!org.apache.pulsar:pulsar-io-distribution'
\
+ -pl
'!org.apache.pulsar:distribution,!org.apache.pulsar:pulsar-offloader-distribution,!org.apache.pulsar:pulsar-server-distribution,!org.apache.pulsar:pulsar-io-distribution,!org.apache.pulsar:pulsar-all-docker-image'
\
Review Comment:
Although I think it's something related to network, it does no harm to
exclude `org.apache.pulsar:pulsar-all-docker-image` in `test_group_other`.
##########
pom.xml:
##########
@@ -1952,7 +1952,9 @@ flexible messaging model and an intuitive client
API.</description>
<goal>report</goal>
</goals>
<configuration>
- <outputDirectory>target/report</outputDirectory>
+ <excludes>
+ <exclude>META-INF/**</exclude>
+ </excludes>
Review Comment:
I don't know the reason you made this change. Could you explain it a bit
@yaalsn?
[The last
time](https://github.com/apache/pulsar/pull/17382#discussion_r971454409) you
changed to `**/*.jar` and now a new change, we need some background here.
However, given that the CI result looks good, I assume this change is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
