liangyepianzhou commented on code in PR #17836:
URL: https://github.com/apache/pulsar/pull/17836#discussion_r990880468


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java:
##########
@@ -1517,4 +1518,57 @@ public void testGetTxnState() throws Exception {
         Transaction abortingTxn = transaction;
         Awaitility.await().until(() -> abortingTxn.getState() == 
Transaction.State.ABORTING);
     }
+
+    @Test
+    public void testUpdateSequenceIdInSyncCodeSegment() throws Exception {
+        String topic = NAMESPACE1 + "/sequenceId";
+        int totalMessage = 10;
+        int threadSize = 30;
+        String topicName = "subscription";
+        ExecutorService executorService = 
Executors.newFixedThreadPool(threadSize);
+
+        //build producer/consumer
+        Producer<byte[]> producer = pulsarClient.newProducer()
+                .topic(topic)
+                .producerName("producer")
+                .sendTimeout(0, TimeUnit.SECONDS)
+                .create();
+
+        Consumer<byte[]> consumer = pulsarClient.newConsumer()
+                .topic(topic)
+                .subscriptionType(SubscriptionType.Exclusive)
+                .subscriptionName(topicName)
+                .subscribe();
+
+        //send and ack messages with transaction
+        Transaction transaction = pulsarClient.newTransaction()
+                .withTransactionTimeout(10, TimeUnit.SECONDS)
+                .build()
+                .get();
+
+        for (int i = 0; i < totalMessage * threadSize; i++) {
+            producer.newMessage().send();
+        }
+
+        CountDownLatch countDownLatch = new CountDownLatch(threadSize);
+        for (int i = 0; i < threadSize; i++) {
+            executorService.submit(() -> {
+                try {
+                    for (int j = 0; j < totalMessage; j++) {
+                        producer.newMessage(transaction).sendAsync();
+                        Message<byte[]> message = consumer.receive();
+                        consumer.acknowledgeAsync(message.getMessageId(),
+                                transaction);
+                    }
+                } catch (Exception e) {
+                    log.error("Failed to send/ack messages with transaction.", 
e);

Review Comment:
   This test has a relatively high probability of failing on committing the 
transaction before the code has been modified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to