nahguam commented on issue #17947: URL: https://github.com/apache/pulsar/issues/17947#issuecomment-1273008191
> > When we speak about "string" format, we are being too general. You can have a many different string formats after all: Base64, Yaml, JSON, etc. So I think it is a mistake to refer to this as string. Instead I'd recommend explicitly naming the format, and also including an extensible option mechanism like: > > ``` > > --format=binary # default for backwards compatibility > > ``` > > > > > > > > > > > > > > > > > > > > > > > > ``` > > --format=json > > ``` > > The actual string format is determined by the schema. Some json, some plain text. They are determined at run time when the new mode is turned on. Perhaps `--format=binary/string` I'm not sure that's true. Yes, the (Pulsar) `GenericRecord` has a `SchemaType` and it might make sense to simply stringify all values. However, how should you stringify `JSON`? An escaped JSON string is frustrating to have to deal with from a user perspective. I'd argue the actual unescaped json node should be returned in that case. I argue a similar point for number and boolean types as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
