mattisonchao commented on code in PR #17611:
URL: https://github.com/apache/pulsar/pull/17611#discussion_r991298428
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
@@ -274,22 +279,29 @@ public void run(Timeout timeout) throws Exception {
@Override
public void close() {
- priorityQueue.close();
if (timeout != null) {
timeout.cancel();
}
+ priorityQueue.close();
Review Comment:
If it's a problem, we can push a new fix. Because it can help cherry-pick
another branch.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
@@ -274,22 +279,29 @@ public void run(Timeout timeout) throws Exception {
@Override
public void close() {
- priorityQueue.close();
if (timeout != null) {
timeout.cancel();
}
+ priorityQueue.close();
Review Comment:
If it's a problem, we can push a new fix. Because it can help cherry-pick to
another branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
