poorbarcode commented on code in PR #16171:
URL: https://github.com/apache/pulsar/pull/16171#discussion_r991859379
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -252,6 +252,10 @@ private void receiveMessageFromConsumer(ConsumerImpl<T>
consumer, boolean batchR
messagesFuture =
consumer.receiveAsync().thenApply(Collections::singletonList);
}
messagesFuture.thenAcceptAsync(messages -> {
+ if (consumer.isDuringSeek()) {
+ receiveMessageFromConsumer(consumer, batchReceive);
Review Comment:
When `incomingMessages` is not empty, there are two possibilities:
1. loop until there is no message in the `incomingMessages`
2. If `ConsumerImpl.seek` fails, the messages have popped from
`incomingMessages` cannot be consumed until `redeliver` executes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
