shibd commented on code in PR #21:
URL: https://github.com/apache/pulsar-client-cpp/pull/21#discussion_r992310766
##########
lib/ConsumerImpl.cc:
##########
@@ -527,11 +495,58 @@ void ConsumerImpl::failPendingReceiveCallback() {
ReceiveCallback callback = pendingReceives_.front();
pendingReceives_.pop();
listenerExecutor_->postWork(std::bind(&ConsumerImpl::notifyPendingReceivedCallback,
- shared_from_this(),
ResultAlreadyClosed, msg, callback));
+ get_shared_this_ptr(),
ResultAlreadyClosed, msg, callback));
}
lock.unlock();
}
+void ConsumerImpl::executeNotifyCallback(Message& msg) {
+ Lock lock(pendingReceiveMutex_);
+ // if asyncReceive is waiting then notify callback without adding to
incomingMessages queue
+ bool asyncReceivedWaiting = !pendingReceives_.empty();
+ ReceiveCallback callback;
+ if (asyncReceivedWaiting) {
+ callback = pendingReceives_.front();
+ pendingReceives_.pop();
+ }
+ lock.unlock();
+
+ // has pending receive, direct callback.
+ if (asyncReceivedWaiting) {
+
listenerExecutor_->postWork(std::bind(&ConsumerImpl::notifyPendingReceivedCallback,
+ get_shared_this_ptr(), ResultOk,
msg, callback));
+ return;
+ }
+
+ // try to add incoming messages.
+ // config_.getReceiverQueueSize() != 0 or waiting For ZeroQueueSize
Message`
+ if (messageListener_ || config_.getReceiverQueueSize() != 0 ||
waitingForZeroQueueSizeMessage) {
+ incomingMessages_.push(msg);
+ incomingMessagesSize_.fetch_add(msg.getLength());
+ }
+
+ // try trigger pending batch messages
+ if (hasEnoughMessagesForBatchReceive()) {
+ ConsumerImplBase::notifyBatchPendingReceivedCallback();
+ }
+}
+
+void ConsumerImpl::notifyBatchPendingReceivedCallback(const
BatchReceiveCallback& callback) {
+ auto messages =
std::make_shared<MessagesImpl>(batchReceivePolicy_.getMaxNumMessages(),
+
batchReceivePolicy_.getMaxNumBytes());
+ Message peekMsg;
+ while (incomingMessages_.peek(peekMsg) && messages->canAdd(peekMsg)) {
+ // decreaseIncomingMessageSize
+ Message msg;
+ incomingMessages_.pop(msg);
+ messageProcessed(msg);
+ messages->add(msg);
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
