BewareMyPower commented on code in PR #37:
URL: https://github.com/apache/pulsar-client-cpp/pull/37#discussion_r992556502
##########
lib/auth/AuthBasic.cc:
##########
@@ -41,6 +41,14 @@ std::string base64_encode(const std::string& s) {
AuthDataBasic::AuthDataBasic(const std::string& username, const std::string&
password) {
commandAuthToken_ = username + ":" + password;
httpAuthToken_ = base64_encode(commandAuthToken_);
+ methodName_ = DEFAULT_BASIC_METHOD_NAME;
+}
Review Comment:
```suggestion
AuthDataBasic::AuthDataBasic(const std::string& username, const std::string&
password)
: AuthDataBasic(username, password, DEFAULT_BASIC_METHOD_NAME) {}
```
Reuse the other constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
