nicoloboschi commented on code in PR #18017:
URL: https://github.com/apache/pulsar/pull/18017#discussion_r993539399
##########
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java:
##########
@@ -280,21 +317,50 @@ private void flush() {
}
}
- if (swapList.size() != count) {
- log.error("Update count {} not match total number of records
{}", count, swapList.size());
- }
-
- // finish flush
- if (log.isDebugEnabled()) {
- log.debug("Finish flush, queue size: {}", swapList.size());
- }
- swapList.clear();
isFlushing.set(false);
+ if (needAnotherRound) {
+ flush();
+ }
} else {
if (log.isDebugEnabled()) {
log.debug("Already in flushing state, will not flush, queue
size: {}", incomingList.size());
}
}
}
+ private void executeBatch(Deque<Record<T>> swapList, PreparedStatement
statement) throws SQLException {
+ final int[] results = statement.executeBatch();
+ Map<Integer, Integer> failuresMapping = null;
+ final boolean useTransactions = jdbcSinkConfig.isUseTransactions();
+
+ for (int r: results) {
+ if (r < 0) {
Review Comment:
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
