merlimat commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r282979558
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -489,6 +490,12 @@
+ " Using a value of 0, is disabling
maxConsumersPerSubscription-limit check.")
private int maxConsumersPerSubscription = 0;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "Max size of messages.",
+ maxValue = Integer.MAX_VALUE -
InternalConfigurationData.MESSAGE_META_SIZE)
+ private int maxMessageSize = 5 * 1024 * 1024;
Review comment:
Use constant for default max size. eg: `Commands.DEFAULT_MAX_MESSAGE_SIZE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
