merlimat commented on code in PR #15:
URL:
https://github.com/apache/pulsar-client-python/pull/15#discussion_r994635233
##########
pulsar/__init__.py:
##########
@@ -347,18 +347,32 @@ class AuthenticationBasic(Authentication):
"""
Basic Authentication implementation
"""
- def __init__(self, username, password):
+ def __init__(self, username=None, password=None, auth_params_string=None):
Review Comment:
We should also accept the `method` argument here, otherwise it might not be
obvious that you can pass it in the json string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
