mattisonchao commented on code in PR #18007:
URL: https://github.com/apache/pulsar/pull/18007#discussion_r996598422
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1906,7 +1906,9 @@ public void asyncMarkDelete(final Position position,
Map<String, Long> propertie
lock.writeLock().lock();
try {
- newPosition = setAcknowledgedPosition(newPosition);
+ if (!newPosition.equals(markDeletePosition)) {
+ newPosition = setAcknowledgedPosition(newPosition);
Review Comment:
I don't understand why we are skipping this method, because I found that
this judgment already exists in `setAcknowledgedPosition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
