jiazhai commented on a change in pull request #4261: [pulsar-broker] add
support of secondary bookie-isolation-group
URL: https://github.com/apache/pulsar/pull/4261#discussion_r283174356
##########
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##########
@@ -353,4 +353,53 @@ public void testOverlappedBookies() throws Exception {
localZkc.delete(ZkBookieRackAffinityMapping.BOOKIE_INFO_ROOT_PATH, -1);
}
+
+ @Test
+ public void testSecondaryIsolationGroupsBookies() throws Exception {
Review comment:
This test looks great. How about also adding a negative test, that test
without `secondaryIsolatedBookieGroup` configured newEnsemble will fail for no
enough bookie?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
