jiazhai commented on a change in pull request #4258: [pulsar-io] hbase sink use 
BooleanSchema encode Boolean data
URL: https://github.com/apache/pulsar/pull/4258#discussion_r283177084
 
 

 ##########
 File path: 
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java
 ##########
 @@ -38,12 +36,9 @@
 @EqualsAndHashCode
 @ToString
 @Accessors(chain = true)
-public class HbaseAbstractConfig implements Serializable {
-
-    private static final long serialVersionUID = 6783394446906640112L;
+public class HbaseAbstractConfig {
 
     @FieldDoc(
-        required = false,
 
 Review comment:
   :) why remove this `required` field? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to