tisonkun commented on code in PR #18101: URL: https://github.com/apache/pulsar/pull/18101#discussion_r999036594
########## site2/docs/reference-cli-pulsar-daemon.md: ########## @@ -1,9 +1,3 @@ ---- -id: reference-cli-pulsar-daemon -title: Pulsar CLI tools - pulsar-daemon -sidebar_label: "cli-pulsar-daemon" ---- - Review Comment: ditto ########## site2/docs/about.md: ########## @@ -55,7 +55,7 @@ You’ll notice an Edit button at the bottom and top of each page. Click it to o :::tip -For how to make contributions to documentation, see [Pulsar Documentation Contribution Guide](https://docs.google.com/document/d/11DTnNPpvcPrebLkMAFcDEIFlD8ARD-k6F-LXoIwdD9Y/edit#). +For how to make contributions to documentation, see [Pulsar Documentation Contribution Guide](../README.md). Review Comment: We don't move this `README.md` file to the site repo. You can use https://github.com/apache/pulsar/blob/master/site2/README.md as a workaround, which I hope we can move into another doc page and update these links to the new page. ########## site2/docs/reference-cli-bookkeeper.md: ########## @@ -1,10 +1,5 @@ ---- -id: reference-cli-bookkeeper -title: Pulsar CLI tools - bookkeeper -sidebar_label: "cli-bookkeeper" ---- Review Comment: Why do you make these chanes? If you'd like to set up redirections, I suggest: ``` ````mdx-code-block import {Redirect} from '@docusaurus/router'; <Redirect to="/reference" /> ```` ``` ########## site2/docs/reference-cli-broker-tool.md: ########## @@ -1,36 +0,0 @@ ---- -id: reference-cli-broker-tool -title: Pulsar CLI tools - broker-tool -sidebar_label: "cli-broker-tool" ---- Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
