srkukarni commented on a change in pull request #4250: Added an explicit field
in the function details for componenttype
URL: https://github.com/apache/pulsar/pull/4250#discussion_r283565833
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/InstanceUtils.java
##########
@@ -89,23 +85,26 @@
}
}
- public ComponentType calculateSubjectType(Function.FunctionDetails
functionDetails) {
+ public Function.FunctionDetails.ComponentType
calculateSubjectType(Function.FunctionDetails functionDetails) {
Review comment:
unittest added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
