eolivelli opened a new pull request, #18133:
URL: https://github.com/apache/pulsar/pull/18133
### Motivation
There are some methods in PulsarRegistrationClient that are not still
implemented correctly according to BP-41 and BP-38.
- getAllBookies() must return all the bookies, not only the bookies that are
up-and-running
- we are not following the changed to the BookieServiceInfo (so if the
bookie changes network address it is not possible to connect to the new network
address)
Therefore the PulsarRegistrationClient is handling too many notifications
about deleted nodes.
### Modifications
* Implement correctly getAllBookies()
* Handle the updates to the Bookie nodes on the MetadataService
* Handle only the deletion of the Bookies nodes
* Add test cases that validate the implementation of BP-38 and BP-41
* Add useful logs in PulsarRegistrationManager
* Handle gracefully the shutdown of PulsarRegistrationManager in case of
errors (I have seen a few failures during the execution of the tests locally on
my laptop)
### Verifying this change
This change added tests.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR
description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
