tisonkun commented on code in PR #18142:
URL: https://github.com/apache/pulsar/pull/18142#discussion_r1001331354
##########
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java:
##########
@@ -334,7 +333,12 @@ private void internalFlush(Deque<Record<T>> swapList)
throws SQLException {
}
}
- private void internalFlushBatch(Deque<Record<T>> swapList,
PreparedStatement currentBatch, int count, long start) throws SQLException {
+ private void internalFlushBatch(
+ Deque<Record<T>> swapList,
+ PreparedStatement currentBatch,
+ int count,
+ long start
+ ) throws SQLException {
Review Comment:
@coderzc I think we should proceed with this patch since it adds a CI task
to prevent regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
