lhotari commented on code in PR #12:
URL:
https://github.com/apache/pulsar-client-reactive/pull/12#discussion_r1001611489
##########
README.adoc:
##########
@@ -73,8 +73,8 @@ ReactiveMessageSender<String> messageSender =
reactivePulsarClient
.topic(topicName)
.maxInflight(100)
.build();
-Mono<MessageId> messageId = messageSender
- .sendMessage(Mono.just(MessageSpec.of("Hello world!")));
+Publisher<MessageId> messageId = messageSender
Review Comment:
I guess we could keep `Mono` here?
##########
README.adoc:
##########
@@ -73,8 +73,8 @@ ReactiveMessageSender<String> messageSender =
reactivePulsarClient
.topic(topicName)
.maxInflight(100)
.build();
-Mono<MessageId> messageId = messageSender
- .sendMessage(Mono.just(MessageSpec.of("Hello world!")));
+Publisher<MessageId> messageId = messageSender
Review Comment:
```suggestion
Mono<MessageId> messageId = messageSender
```
##########
pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageSender.java:
##########
@@ -192,11 +192,12 @@ private Mono<MessageId> createMessageMono(MessageSpec<T>
messageSpec, Producer<T
}
@Override
- public Flux<MessageId> sendMessages(Flux<MessageSpec<T>> messageSpecs) {
+ public Flux<MessageId> sendAll(Publisher<MessageSpec<T>> messageSpecs) {
Review Comment:
```suggestion
public Flux<MessageId> send(Publisher<MessageSpec<T>> messageSpecs) {
```
I'd prefer `send` over `sendAll`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
