WJL3333 commented on code in PR #18166:
URL: https://github.com/apache/pulsar/pull/18166#discussion_r1002847170
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java:
##########
@@ -133,6 +133,11 @@ public static String splitPath(String source, int slice) {
* @return the web service caller identification
*/
public String clientAppId() {
+ return "clientIP=" + httpRequest.getRemoteAddr() +
+ "clientRole=" +
httpRequest.getAttribute(AuthenticationFilter.AuthenticatedRoleAttributeName);
+ }
+
+ public String clientRole() {
Review Comment:
thinks for review. i tried before. but after analysis the code, some code
path use clientAppId to get authorization clientRole, direct change origin
clientAppId may introduce other bug. sorry for change too much code but i think
may be we can find a way to better make the change simle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
