Demogorgon314 commented on code in PR #64:
URL: https://github.com/apache/pulsar-client-cpp/pull/64#discussion_r1002905767


##########
.clang-format:
##########
@@ -19,7 +19,7 @@
 BasedOnStyle: Google
 IndentWidth: 4
 ColumnLimit: 110
-SortIncludes: false
+SortIncludes: true

Review Comment:
   Interesting. Looks like the `clang-format version 11.1.0` changed the option 
to boolean, and the `clang-format version 14.0.6` changed back. 
   
   ```
   ➜   clang-format -version
   clang-format version 14.0.6
   ➜  clang-format -style=llvm -dump-config | grep SortIncludes
   SortIncludes:    CaseSensitive
   
   ➜  clang-format-11 -version
   clang-format version 11.1.0
   ➜  clang-format-11 -style=llvm -dump-config | grep SortIncludes
   SortIncludes:    true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to