Demogorgon314 commented on code in PR #18150:
URL: https://github.com/apache/pulsar/pull/18150#discussion_r1002934871
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/LocalBrokerDataTest.java:
##########
@@ -0,0 +1,21 @@
+package org.apache.pulsar.broker.loadbalance;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.pulsar.policies.data.loadbalancer.LocalBrokerData;
+import org.testng.annotations.Test;
+
+@Slf4j
+@Test(groups = "broker")
+public class LocalBrokerDataTest {
+ /*
+ Ensuming that there no bundleStats field in the json string serialized
from LocalBrokerData.
+ */
+ @Test
+ public void testSerializeLocalBrokerData() throws JsonProcessingException {
+ ObjectMapper objectMapper = new ObjectMapper();
+ LocalBrokerData localBrokerData = new LocalBrokerData();
+ assert
!objectMapper.writeValueAsString(localBrokerData).contains("bundleStats");
Review Comment:
Use `org.testng.Assert.assertTrue` here.
Or
```
assertFalse(objectMapper.writeValueAsString(localBrokerData).contains("bundleStats"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
