tongsucn opened a new pull request, #66:
URL: https://github.com/apache/pulsar-client-cpp/pull/66

   Fixes #65
   
   ### Motivation
   
   Improve data consuming performance by adding new interfaces on `class 
Message` and `class SharedBuffer`.
   
   ### Modifications
   
   Adding two functions:
   
   `lib/SharedBuffer.h`
   
   ```cpp
   bool SharedBuffer::pop(std::string &target)
   ```
   
   `lib/Message.cc`
   
   ```cpp
   void Message::moveDataIntoString(std::string &data)
   ```
   
   ### Verifying this change
   
   Below TBD
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to