tisonkun commented on code in PR #263:
URL: https://github.com/apache/pulsar-site/pull/263#discussion_r1003917818
##########
site2/tools/build-site.sh:
##########
@@ -58,7 +58,7 @@ rm -rf "$CONTENT_DIR"
mkdir -p "$CONTENT_DIR"
cp -R "$GEN_SITE_DIR"/reference "$CONTENT_DIR"
# cp -R "$GEN_SITE_DIR"/api "$CONTENT_DIR"
-cp -R ./build/* "$CONTENT_DIR"
+cp -R ./build/ "$CONTENT_DIR"
cp -R "$WEBSITE_DIR"/static/swagger/* "$CONTENT_DIR"/swagger/
Review Comment:
Perhaps we don't need this line since the static swagger is copyed at the
line above.
##########
site2/tools/publish-website.sh:
##########
@@ -65,7 +65,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
| grep -v $PULSAR_SITE_TMP/content/.htaccess \
| xargs rm -rf
fi
- cp -r $GENERATED_SITE_DIR/content/* $PULSAR_SITE_TMP/content
+ cp -r $GENERATED_SITE_DIR/content/ $PULSAR_SITE_TMP/content
Review Comment:
Perhaps using `-R` to avoid behavior inconsistency. For the implementation
on a darwin OS:
```
Historic versions of the cp utility had a -r option. This
implementation
supports that option, however, its behavior is different from historical
FreeBSD behavior. Use of this option is strongly discouraged as the
behavior is implementation-dependent. In FreeBSD, -r is a synonym for
-RL
and works the same unless modified by other flags. Historical
implementations of -r differ as they copy special files as normal files
while recreating a hierarchy.
```
##########
site2/website-next/scripts/split-version-build.sh:
##########
@@ -76,5 +76,6 @@ done <scripts/.versions
cp -r build-assets/* build/assets/
rm -rf build-assets
+cp static/.htaccess build/
Review Comment:
It seems that we don't need this line then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
