[pulsar] branch master updated: [improve][client]Remove unused check for topics isEmpty (#18185)

[penghui]

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 58765c144ca [improve][client]Remove unused check for topics isEmpty 
(#18185)
58765c144ca is described below

commit 58765c144ca31ea27fe4ff23d60a14f26559db72
Author: houxiaoyu <houxia...@apache.org>
AuthorDate: Tue Oct 25 22:08:36 2022 +0800

    [improve][client]Remove unused check for topics isEmpty (#18185)
---
 .../org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java    | 3 +--
 .../apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java    | 8 ++++++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git 
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
 
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
index 16a956a4b6b..6306578008a 100644
--- 
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
+++ 
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
@@ -173,8 +173,7 @@ public class MultiTopicsConsumerImpl<T> extends 
ConsumerBase<T> {
             return;
         }
 
-        checkArgument(conf.getTopicNames().isEmpty()
-                || topicNamesValid(conf.getTopicNames()), "Topics is empty or 
invalid.");
+        checkArgument(topicNamesValid(conf.getTopicNames()), "Topics is 
invalid.");
 
         List<CompletableFuture<Void>> futures = conf.getTopicNames().stream()
                 .map(t -> subscribeAsync(t, createTopicIfDoesNotExist))
diff --git 
a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
 
b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
index e3dd27b636b..febec2bff32 100644
--- 
a/pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
+++ 
b/pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
@@ -185,6 +185,14 @@ public class MultiTopicsConsumerImplTest {
         assertFalse(consumer.hasPendingBatchReceive());
     }
 
+    @Test(expectedExceptions = {IllegalArgumentException.class})
+    public void testValidTopicNames() {
+        ConsumerConfigurationData<byte[]> consumerConfData = new 
ConsumerConfigurationData<>();
+        consumerConfData.setSubscriptionName("subscriptionName");
+        
consumerConfData.setTopicNames(Sets.newHashSet("persistent://public/invalid-topic"));
+        createMultiTopicsConsumer(consumerConfData);
+    }
+
     @Test
     public void testConsumerCleanupOnSubscribeFailure() {
         ConsumerConfigurationData<byte[]> consumerConfData = new 
ConsumerConfigurationData<>();