sijie commented on issue #4272: With multi-host HTTP client, stop after trying 
all the addresses
URL: https://github.com/apache/pulsar/pull/4272#issuecomment-492393029
 
 
   I think the default value was set to 60s in this pull request, but there was 
a conflicting PR #4235 merged before merging this PR hence the problem was not 
captured by the CI.
   
   I am not sure if we should break the loop after retrying all the hosts or 
shall we just honor to the request timeout that the user sets. We can adjust 
the request timeout for our tests. we can continue the discussion in #4272
   
   The motivation of having request timeout is that pulsar client should be 
honored to request timeout and the cli should try to do retries before request 
timeout. so I think the right fix is to fix the default value or change the 
default value for tests as it is a side effort introduced by #4235 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to