VagulaSundararajan opened a new issue #4274: Prometheus Topic stats with remote 
cluster issue
URL: https://github.com/apache/pulsar/issues/4274
 
 
   **Describe the bug**
   The remote cluster label is appended without closing the topic label 
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to Prometheus broker metrics in which the topic has remote cluster
   2. check the pulsar_replication_* types
   4. The topic label has value like
   # TYPE pulsar_replication_rate_in gauge
   
pulsar_replication_rate_in{cluster="cluster",namespace="ns",topic="persistent://ns/ns/topicnameremote_cluster="vmb-us-west-rocklin-cluster"}
 0.0 1557859327946
   
   **Expected behavior**
   Class:: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java
   Method :: metricWithRemoteCluster
   the current code is 
   
stream.write("\",topic=\"").write(topic).write("remote_cluster=\"").write(remoteCluster).write("\"}
 ");
   
   it should be
   
stream.write("\",topic=\"").write(topic).write("\","remote_cluster=\"").write(remoteCluster).write("\"}
 ");
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to