poorbarcode opened a new pull request, #18220:
URL: https://github.com/apache/pulsar/pull/18220

   ### Motivation
   
   https://github.com/poorbarcode/pulsar/actions/runs/3267034877/jobs/5371836130
   https://github.com/apache/pulsar/actions/runs/3242148385/jobs/5326408439
   
   The original implementation determines whether to wait for the creation of 
`__chang_event` based on whether a broker has taken ownership of the bundle or 
not. However, there are often 'set namespace policy', 'unload namespace', 
'delete namespace', 'split bundle', and other operations in the test case. When 
the `bundle unload` and the 'bundle check` concurrently execute, the method 
`deleteNamespaceGraceFully` will run unstably.
   
   ### Modifications
   - Instead of relying on 'bundle owned' to determine whether to wait for the 
creation of topic `__change_event`, change to track the creation of all system 
topic clients (`readers & writers`) and wait for all clients(`readers & 
writers`) to be created finished before deleting the namespace
   - Originally, `deleteNamespaceGraceFully` in class `BrokerTestBase`, and 
then `MockedPulsarServiceBaseTest` called 
`BrokerTestBase.deleteNamespaceGraceFully()`. But `MockedPulsarServiceBaseTest` 
is the super class of `BrokerTestBase`, so move method 
`deleteNamespaceGraceFully` to `MockedPulsarServiceBaseTest`.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local 
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR 
description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:
   
   - https://github.com/poorbarcode/pulsar/pull/31
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to