lhotari commented on code in PR #876:
URL: https://github.com/apache/pulsar-client-go/pull/876#discussion_r1008639592
##########
pulsar/producer_impl.go:
##########
@@ -90,7 +93,7 @@ func newProducer(client *client, options *ProducerOptions)
(*producer, error) {
if options.BatchingMaxPublishDelay <= 0 {
options.BatchingMaxPublishDelay = defaultBatchingMaxPublishDelay
}
- if options.PartitionsAutoDiscoveryInterval <= 0 {
+ if options.PartitionsAutoDiscoveryInterval <=
minPartitionAutoDiscoveryInterval {
Review Comment:
Wouldn't this be a problem if someone has set the value to <= 1 second?
There's no error message and the default 1 minute gets used. I would expect at
least a warning message. The case of 0 is different since in that case, the
default value is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
