coderzc opened a new pull request, #18268:
URL: https://github.com/apache/pulsar/pull/18268
Fixes
* #18231
### Motivation
When using `newThread` in `ExecutorProvider.ExtendedThreadFactory`
concurrently, we can return an already running Thread lead to occur
`IllegalThreadStateException`.
```java
2022-10-31T18:48:53,562 - WARN -
[pulsar-websocket-web-127-9:AbstractChannel$AbstractUnsafe@490] - Force-closing
a channel whose registration task was not accepted by an event loop: [id:
0x0ee22409]
java.lang.IllegalThreadStateException: null
at java.lang.Thread.start(Thread.java:793) ~[?:?]
at
io.netty.util.concurrent.ThreadPerTaskExecutor.execute(ThreadPerTaskExecutor.java:32)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.internal.ThreadExecutorMap$1.execute(ThreadExecutorMap.java:57)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.SingleThreadEventExecutor.doStartThread(SingleThreadEventExecutor.java:984)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.SingleThreadEventExecutor.startThread(SingleThreadEventExecutor.java:953)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:825)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:815)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.channel.AbstractChannel$AbstractUnsafe.register(AbstractChannel.java:483)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:87)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:81)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.channel.MultithreadEventLoopGroup.register(MultithreadEventLoopGroup.java:86)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.bootstrap.AbstractBootstrap.initAndRegister(AbstractBootstrap.java:323)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at io.netty.bootstrap.Bootstrap.doResolveAndConnect(Bootstrap.java:155)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at io.netty.bootstrap.Bootstrap.connect(Bootstrap.java:148)
~[netty-transport-4.1.77.Final.jar:4.1.77.Final]
at
org.asynchttpclient.netty.channel.NettyChannelConnector.connect0(NettyChannelConnector.java:81)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.channel.NettyChannelConnector.connect(NettyChannelConnector.java:69)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.request.NettyRequestSender$1.lambda$onSuccess$0(NettyRequestSender.java:315)
~[async-http-client-2.12.1.jar:?]
at
io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:578)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:552)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:491)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:184)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:35)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
org.asynchttpclient.netty.request.NettyRequestSender$1.onSuccess(NettyRequestSender.java:313)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.request.NettyRequestSender$1.onSuccess(NettyRequestSender.java:301)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.SimpleFutureListener.operationComplete(SimpleFutureListener.java:24)
~[async-http-client-2.12.1.jar:?]
at
io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:578)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:552)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:491)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:184)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:35)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at
org.asynchttpclient.netty.request.NettyRequestSender.sendRequestWithNewChannel(NettyRequestSender.java:301)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.request.NettyRequestSender.sendRequestWithCertainForceConnect(NettyRequestSender.java:142)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.netty.request.NettyRequestSender.sendRequest(NettyRequestSender.java:113)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.DefaultAsyncHttpClient.execute(DefaultAsyncHttpClient.java:259)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.DefaultAsyncHttpClient.executeRequest(DefaultAsyncHttpClient.java:228)
~[async-http-client-2.12.1.jar:?]
at
org.asynchttpclient.BoundRequestBuilder.execute(BoundRequestBuilder.java:39)
~[async-http-client-2.12.1.jar:?]
at
org.apache.pulsar.client.impl.HttpClient.lambda$get$2(HttpClient.java:226)
~[classes/:?]
at
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
~[?:?]
at
java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:887)
~[?:?]
at
java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2325)
~[?:?]
at org.apache.pulsar.client.impl.HttpClient.get(HttpClient.java:200)
~[classes/:?]
at
org.apache.pulsar.client.impl.HttpLookupService.getPartitionedTopicMetadata(HttpLookupService.java:117)
~[classes/:?]
at
org.apache.pulsar.client.impl.PulsarClientImpl.getPartitionedTopicMetadata(PulsarClientImpl.java:1043)
~[classes/:?]
at
org.apache.pulsar.client.impl.PulsarClientImpl.getPartitionedTopicMetadata(PulsarClientImpl.java:1029)
~[classes/:?]
at
org.apache.pulsar.client.impl.PulsarClientImpl.createProducerAsync(PulsarClientImpl.java:373)
~[classes/:?]
at
org.apache.pulsar.client.impl.PulsarClientImpl.createProducerAsync(PulsarClientImpl.java:362)
~[classes/:?]
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.createAsync(ProducerBuilderImpl.java:109)
~[classes/:?]
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:86)
~[classes/:?]
at
org.apache.pulsar.websocket.ProducerHandler.<init>(ProducerHandler.java:94)
~[classes/:?]
at
org.apache.pulsar.websocket.WebSocketProducerServlet.lambda$configure$0(WebSocketProducerServlet.java:43)
~[classes/:?]
at
org.eclipse.jetty.websocket.server.WebSocketServerFactory.acceptWebSocket(WebSocketServerFactory.java:275)
~[websocket-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.websocket.server.WebSocketServerFactory.acceptWebSocket(WebSocketServerFactory.java:260)
~[websocket-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.websocket.servlet.WebSocketServlet.service(WebSocketServlet.java:160)
~[websocket-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
~[javax.servlet-api-3.1.0.jar:3.1.0]
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.servlets.QoSFilter.doFilter(QoSFilter.java:202)
~[jetty-servlets-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
~[jetty-servlet-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:234)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.server.Server.handle(Server.java:516)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
~[jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
~[jetty-io-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
~[jetty-io-9.4.48.v20220622.jar:9.4.48.v20220622]
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
~[jetty-io-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
~[jetty-util-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
~[jetty-util-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
~[jetty-util-9.4.48.v20220622.jar:9.4.48.v20220622]
at
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.produce(EatWhatYouKill.java:137)
~[jetty-util-9.4.48.v20220622.jar:9.4.48.v20220622]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
~[?:?]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
~[?:?]
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
~[netty-common-4.1.77.Final.jar:4.1.77.Final]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
```
### Modifications
return a local variable in `newThread`.
Add `volatile` to the thread variable.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR
description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
