Gleiphir2769 opened a new pull request, #880:
URL: https://github.com/apache/pulsar-client-go/pull/880

   Master Issue: #877 
   
   ### Motivation
   
   The producer `Send()` is a sync method. It depends on closing doneCh by 
`sendRequest.callback()` to finish waiting. But there are some return case does 
not call `sendRequest.callback()`, which may cause `Send()` stuck.
   
   
https://github.com/apache/pulsar-client-go/blob/5679f1f7b3840184b8947b5b8c8170fec181eecc/pulsar/producer_partition.go#L492-L498
   
   ### Modifications
   
   Add the missed `sendRequest.callback()`.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
     - *Extended integration test for recovery after broker failure*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to