nodece commented on code in PR #18218:
URL: https://github.com/apache/pulsar/pull/18218#discussion_r1010202607
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java:
##########
@@ -267,6 +275,97 @@ public void testOffloadPoliciesAppliedApi() throws
Exception {
-> assertEquals(admin.topics().getOffloadPolicies(topicName,
true), brokerPolicies));
}
+
+ @Test
+ public void testSetNamespaceOffloadPolicies() throws Exception {
+ conf.setManagedLedgerOffloadThresholdInSeconds(100);
+ conf.setManagedLedgerOffloadAutoTriggerSizeThresholdBytes(100);
+
+ OffloadPoliciesImpl policies = new OffloadPoliciesImpl();
+ policies.setManagedLedgerOffloadThresholdInBytes(200L);
+ policies.setManagedLedgerOffloadThresholdInSeconds(200L);
+ policies.setManagedLedgerOffloadDeletionLagInMillis(400L);
+ policies.setManagedLedgerOffloadDriver("s3");
+ policies.setManagedLedgerOffloadBucket("buck2");
+
+ admin.namespaces().setOffloadThresholdInSeconds(myNamespace, 300);
+ assertEquals(300,
admin.namespaces().getOffloadThresholdInSeconds(myNamespace));
+
+ admin.namespaces().setOffloadPolicies(myNamespace, policies);
+ assertEquals(policies,
admin.namespaces().getOffloadPolicies(myNamespace));
+
+ String topicName = testTopic + UUID.randomUUID();
+ try {
+ Topic topic =
pulsar.getBrokerService().getOrCreateTopic(topicName).get(10, TimeUnit.SECONDS);
+ assertNotNull(topic);
+
+ assertTrue(topic instanceof PersistentTopic);
+
+ PersistentTopic persistentTopic = (PersistentTopic) topic;
+ ManagedLedger ledger = persistentTopic.getManagedLedger();
+ ManagedLedgerConfig config = ledger.getConfig();
+ OffloadPolicies policies1 =
config.getLedgerOffloader().getOffloadPolicies();
+
+ assertEquals(policies1.getManagedLedgerOffloadThresholdInBytes(),
policies.getManagedLedgerOffloadThresholdInBytes());
+
assertEquals(policies1.getManagedLedgerOffloadThresholdInSeconds(),
policies.getManagedLedgerOffloadThresholdInSeconds());
+ } finally {
+ pulsar.getBrokerService().deleteTopic(topicName, true);
+ }
+ }
+
+ @Test
+ public void testSetTopicOffloadPolicies() throws Exception {
+ conf.setManagedLedgerOffloadThresholdInSeconds(100);
+ conf.setManagedLedgerOffloadAutoTriggerSizeThresholdBytes(100);
+
+ OffloadPoliciesImpl namespacePolicies = new OffloadPoliciesImpl();
+ namespacePolicies.setManagedLedgerOffloadThresholdInBytes(200L);
+ namespacePolicies.setManagedLedgerOffloadThresholdInSeconds(200L);
+ namespacePolicies.setManagedLedgerOffloadDeletionLagInMillis(400L);
+ namespacePolicies.setManagedLedgerOffloadDriver("s3");
+ namespacePolicies.setManagedLedgerOffloadBucket("buck2");
+
+ admin.namespaces().setOffloadThresholdInSeconds(myNamespace, 300);
+ assertEquals(300,
admin.namespaces().getOffloadThresholdInSeconds(myNamespace));
Review Comment:
```suggestion
assertEquals(admin.namespaces().getOffloadThresholdInSeconds(myNamespace), 300);
```
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java:
##########
@@ -267,6 +275,97 @@ public void testOffloadPoliciesAppliedApi() throws
Exception {
-> assertEquals(admin.topics().getOffloadPolicies(topicName,
true), brokerPolicies));
}
+
+ @Test
+ public void testSetNamespaceOffloadPolicies() throws Exception {
+ conf.setManagedLedgerOffloadThresholdInSeconds(100);
+ conf.setManagedLedgerOffloadAutoTriggerSizeThresholdBytes(100);
+
+ OffloadPoliciesImpl policies = new OffloadPoliciesImpl();
+ policies.setManagedLedgerOffloadThresholdInBytes(200L);
+ policies.setManagedLedgerOffloadThresholdInSeconds(200L);
+ policies.setManagedLedgerOffloadDeletionLagInMillis(400L);
+ policies.setManagedLedgerOffloadDriver("s3");
+ policies.setManagedLedgerOffloadBucket("buck2");
+
+ admin.namespaces().setOffloadThresholdInSeconds(myNamespace, 300);
+ assertEquals(300,
admin.namespaces().getOffloadThresholdInSeconds(myNamespace));
+
+ admin.namespaces().setOffloadPolicies(myNamespace, policies);
+ assertEquals(policies,
admin.namespaces().getOffloadPolicies(myNamespace));
+
+ String topicName = testTopic + UUID.randomUUID();
+ try {
+ Topic topic =
pulsar.getBrokerService().getOrCreateTopic(topicName).get(10, TimeUnit.SECONDS);
+ assertNotNull(topic);
+
+ assertTrue(topic instanceof PersistentTopic);
+
+ PersistentTopic persistentTopic = (PersistentTopic) topic;
+ ManagedLedger ledger = persistentTopic.getManagedLedger();
+ ManagedLedgerConfig config = ledger.getConfig();
+ OffloadPolicies policies1 =
config.getLedgerOffloader().getOffloadPolicies();
+
+ assertEquals(policies1.getManagedLedgerOffloadThresholdInBytes(),
policies.getManagedLedgerOffloadThresholdInBytes());
+
assertEquals(policies1.getManagedLedgerOffloadThresholdInSeconds(),
policies.getManagedLedgerOffloadThresholdInSeconds());
+ } finally {
+ pulsar.getBrokerService().deleteTopic(topicName, true);
+ }
+ }
+
+ @Test
+ public void testSetTopicOffloadPolicies() throws Exception {
+ conf.setManagedLedgerOffloadThresholdInSeconds(100);
+ conf.setManagedLedgerOffloadAutoTriggerSizeThresholdBytes(100);
+
+ OffloadPoliciesImpl namespacePolicies = new OffloadPoliciesImpl();
+ namespacePolicies.setManagedLedgerOffloadThresholdInBytes(200L);
+ namespacePolicies.setManagedLedgerOffloadThresholdInSeconds(200L);
+ namespacePolicies.setManagedLedgerOffloadDeletionLagInMillis(400L);
+ namespacePolicies.setManagedLedgerOffloadDriver("s3");
+ namespacePolicies.setManagedLedgerOffloadBucket("buck2");
+
+ admin.namespaces().setOffloadThresholdInSeconds(myNamespace, 300);
+ assertEquals(300,
admin.namespaces().getOffloadThresholdInSeconds(myNamespace));
+
+ admin.namespaces().setOffloadPolicies(myNamespace, namespacePolicies);
+ assertEquals(namespacePolicies,
admin.namespaces().getOffloadPolicies(myNamespace));
Review Comment:
```suggestion
assertEquals(admin.namespaces().getOffloadPolicies(myNamespace),
namespacePolicies);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
