WJL3333 commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010303185
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void
internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
.thenCompose(owned -> {
if (owned) {
return getTopicReferenceAsync(partition)
- .thenApply(ref ->
- ref.getStats(getPreciseBacklog,
subscriptionBacklogSize,
- getEarliestTimeInBacklog));
+ .thenApply(ref ->
+
ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
Review Comment:
i think we can add some class `XXXXOption` to encapsulate these boolean
config.
if we add more boolean config it will be easy to just change `XXXXOption`
without too much change the related code. And it improves the code quality to
make method signature with less parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
