315157973 commented on code in PR #18283:
URL: https://github.com/apache/pulsar/pull/18283#discussion_r1011230615
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1170,6 +1179,9 @@ private CompletableFuture<Void> delete(boolean
failIfHasSubscriptions,
.map(PersistentSubscription::getName).toList();
return FutureUtil.failedFuture(
new TopicBusyException("Topic has subscriptions did
not catch up: " + backlogSubs));
+ } else if (!closeIfClientsConnected && currentUsageCount() != 0 &&
!failIfHasBacklogs) {
+ return FutureUtil.failedFuture(new TopicBusyException(
+ "Topic has " + currentUsageCount() + " connected
producers/consumers"));
Review Comment:
It needs to fail as long as there are connections, so it has nothing to do
with `!failIfHasBacklogs`.
Or if failIfHasBacklogs is triggered, the error message returned should not
be like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
