poorbarcode commented on code in PR #18307:
URL: https://github.com/apache/pulsar/pull/18307#discussion_r1012483348
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1207,7 +1207,14 @@ private CompletableFuture<Void> delete(boolean
failIfHasSubscriptions,
brokerService.deleteTopicAuthenticationWithRetry(topic,
deleteTopicAuthenticationFuture, 5);
deleteTopicAuthenticationFuture.thenCompose(__ ->
deleteSchema())
- .thenCompose(__ -> deleteTopicPolicies())
+ .thenCompose(__ -> {
+ if
(!this.getBrokerService().getPulsar().getBrokerService()
Review Comment:
Is only the system topic `__change_event` not required policies?
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java:
##########
@@ -231,7 +232,7 @@ public void testCreateTransactionSystemTopic() throws
Exception {
// getList does not include transaction system topic
List<String> list = admin.topics().getList(NAMESPACE1);
- assertEquals(list.size(), 2);
+ assertEquals(list.size(), 1);
Review Comment:
Seems we don't care how many topics here, suggestion
`assertFalse(list.isEmpty())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
