codelipenghui opened a new pull request, #18320: URL: https://github.com/apache/pulsar/pull/18320
### Motivation The current behavior for the `delete_when_subscriptions_caught_up` strategy is not expected. The active consumer will not be closed even if users enable `delete_when_subscriptions_caught_up` and there are no backlogs for the topic. It should be the part that #6077 has missed. And Sijie has mentioned in the comment https://github.com/apache/pulsar/pull/6077#pullrequestreview-344643883. To correct the behavior of `delete_when_subscriptions_caught_up` ### Modifications Close active consumers if `delete_when_subscriptions_caught_up` is applied and there are no backlogs for the topic. So that the topic can be cleaned up properly by the topic GC thread. ### Verifying this change Updated the existing test. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
