congbobo184 commented on code in PR #18318:
URL: https://github.com/apache/pulsar/pull/18318#discussion_r1012937720
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java:
##########
@@ -343,9 +343,6 @@ public void sendEndTxnErrorResponse(long requestId, TxnID
txnID, ServerError err
safeIntercept(command, cnx);
ByteBuf outBuf = Commands.serializeWithSize(command);
cnx.ctx().writeAndFlush(outBuf, cnx.ctx().voidPromise());
- if (this.interceptor != null) {
- this.interceptor.txnEnded(txnID.toString(), TxnAction.ABORT_VALUE);
- }
Review Comment:
If end transaction throws an exception, it doesn't mean the transaction has
been ended, so we don't need to record it as `aborted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
