ericsyh commented on code in PR #18015: URL: https://github.com/apache/pulsar/pull/18015#discussion_r1013620789
########## site2/docs/helm-deploy.md: ########## @@ -284,15 +287,15 @@ To enable authorization, you can include this option in the `helm install` comma --set auth.authorization.enabled=true ``` -### CPU and RAM resource requirements +#### CPU and RAM resource requirements By default, the resource requests and the number of replicas for the Pulsar components in the Pulsar Helm chart are adequate for small production deployment. If you deploy a non-production instance, you can reduce the defaults to fit into a smaller cluster. Once you have all of your configuration options collected, you can install dependent charts before installing the Pulsar Helm chart. ## Install dependent charts -### Install local storage provisioner +#### Install local storage provisioner Review Comment: Somehow is correct but I don't think it's an optional task because there is no binding relationship between using local persistent volumes and installing `streamnative/local-storage-provisioner`. If I want to deploy `pulsar-helm-chart` on k8s with local persistent volumes, there are some provisioners to choose from: * https://github.com/rancher/local-path-provisioner * https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner, actually it is the upstream of ` streamnative/local-storage-provisioner` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
