poorbarcode commented on code in PR #18323:
URL: https://github.com/apache/pulsar/pull/18323#discussion_r1013729614
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java:
##########
@@ -144,13 +144,17 @@ default void setEntryTimestamp(long entryTimestamp) {
void removeProducer(Producer producer);
+ /**
+ * return if transaction disabled when call
checkIfTransactionBufferRecoverCompletely
+ */
+ CompletableFuture<Void> TRANSACTION_DISABLED =
CompletableFuture.completedFuture(null);
Review Comment:
I feel that this variable definition in class `Topic` is not reasonable, and
the naming is not easy to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
