eolivelli commented on code in PR #13298:
URL: https://github.com/apache/pulsar/pull/13298#discussion_r1014040703
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConfigurationDataUtils.java:
##########
@@ -51,20 +51,17 @@ public static ObjectMapper getThreadLocal() {
return mapper.get();
}
- private ConfigurationDataUtils() {}
+ private ConfigurationDataUtils() {
+ }
public static <T> T loadData(Map<String, Object> config,
- T existingData,
- Class<T> dataCls) {
+ T existingData) {
Review Comment:
yes, I think it could have been used by users.
we should keep the old, make it work the same way as before and use the new
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
