michaeljmarshall commented on code in PR #18344:
URL: https://github.com/apache/pulsar/pull/18344#discussion_r1014281062
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java:
##########
@@ -87,7 +87,39 @@ public ConsumerBuilderImpl(PulsarClientImpl client,
Schema<T> schema) {
@Override
public ConsumerBuilder<T> loadConf(Map<String, Object> config) {
- this.conf = ConfigurationDataUtils.loadData(config, conf,
ConsumerConfigurationData.class);
+ MessageListener<T> messageListener =
+ (MessageListener<T>) config.getOrDefault("messageListener",
this.conf.getMessageListener());
+ ConsumerEventListener consumerEventListener =
+ (ConsumerEventListener)
config.getOrDefault("consumerEventListener",
this.conf.getConsumerEventListener());
+ RedeliveryBackoff negativeAckRedeliveryBackoff = (RedeliveryBackoff)
config
+ .getOrDefault("negativeAckRedeliveryBackoff",
this.conf.getNegativeAckRedeliveryBackoff());
+ RedeliveryBackoff ackTimeoutRedeliveryBackoff = (RedeliveryBackoff)
config
+ .getOrDefault("ackTimeoutRedeliveryBackoff",
this.conf.getAckTimeoutRedeliveryBackoff());
+ CryptoKeyReader cryptoKeyReader =
+ (CryptoKeyReader) config.getOrDefault("cryptoKeyReader",
this.conf.getCryptoKeyReader());
+ MessageCrypto messageCrypto =
+ (MessageCrypto) config.getOrDefault("messageCrypto",
this.conf.getMessageCrypto());
+ BatchReceivePolicy batchReceivePolicy =
+ (BatchReceivePolicy) config.getOrDefault("batchReceivePolicy",
this.conf.getBatchReceivePolicy());
+ KeySharedPolicy keySharedPolicy =
+ (KeySharedPolicy) config.getOrDefault("keySharedPolicy",
this.conf.getKeySharedPolicy());
+ MessagePayloadProcessor payloadProcessor =
+ (MessagePayloadProcessor) config.getOrDefault("payloadProcessor",
this.conf.getPayloadProcessor());
+
+ ConsumerConfigurationData<T> configurationData =
+ ConfigurationDataUtils.loadData(config, conf,
ConsumerConfigurationData.class);
+
+ configurationData.setMessageListener(messageListener);
+ configurationData.setConsumerEventListener(consumerEventListener);
+
configurationData.setNegativeAckRedeliveryBackoff(negativeAckRedeliveryBackoff);
+
configurationData.setAckTimeoutRedeliveryBackoff(ackTimeoutRedeliveryBackoff);
Review Comment:
Is it worth just making these two (and some of the others) serializable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
