onobc commented on code in PR #18358:
URL: https://github.com/apache/pulsar/pull/18358#discussion_r1014915253
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminImpl.java:
##########
@@ -215,13 +212,35 @@ public PulsarAdminImpl(String serviceUrl,
}
}
+ private Authentication determineAuth(ClientConfigurationData conf) throws
PulsarClientException {
+ if (conf == null) {
+ return new AuthenticationDisabled();
+ }
+ maybeSetAuthOnConf(conf);
+ return conf.getAuthentication();
+ }
+
+ private void maybeSetAuthOnConf(ClientConfigurationData conf) throws
PulsarClientException {
+ if (StringUtils.isBlank(conf.getAuthPluginClassName())
Review Comment:
This is functionally the same thing the regular client does
[here](https://github.com/apache/pulsar/blob/a2c15340d3a73401b57574a4032ca375bde502bc/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java#L192).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
