RobertIndie commented on code in PR #18343:
URL: https://github.com/apache/pulsar/pull/18343#discussion_r1015098543


##########
site2/docs/security-basic-auth.md:
##########
@@ -73,40 +73,6 @@ basicAuthConf=file:///path/to/.htpasswd
 # Authentication settings of the broker itself. Used when the broker connects 
to other brokers, either in same or other clusters
 
brokerClientAuthenticationPlugin=org.apache.pulsar.client.impl.auth.AuthenticationBasic
 brokerClientAuthenticationParameters={"userId":"superuser","password":"admin"}
-
-# If this flag is set then the broker authenticates the original Auth data
-# else it just accepts the originalPrincipal and authorizes it (if required).
-authenticateOriginalAuthData=true
-```
-
-:::note
-
-You can also set an environment variable named `PULSAR_EXTRA_OPTS` and the 
value is `-Dpulsar.auth.basic.conf=/path/to/.htpasswd`. Pulsar reads this 
environment variable to implement HTTP basic authentication.
-
-:::

Review Comment:
   Seems we still need this Note?



##########
site2/docs/security-basic-auth.md:
##########
@@ -73,40 +73,6 @@ basicAuthConf=file:///path/to/.htpasswd
 # Authentication settings of the broker itself. Used when the broker connects 
to other brokers, either in same or other clusters

Review Comment:
   ```suggestion
   # Authentication settings of the broker itself. Used when the broker 
connects to other brokers, or when the proxy connects to brokers, either in 
same or other clusters
   ```
   
   For other pages as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to