equanz commented on PR #18254: URL: https://github.com/apache/pulsar/pull/18254#issuecomment-1305417873
In my understanding, old partitioned producer clients are not aggregated by producerName completely. So, this PR introduce breaking changes to them. Partitioned producers have the same producerName between partitions as default from https://github.com/apache/pulsar/pull/10279 commit. Therefore, I kept a list-indexed aggregation for backward compatibility. https://github.com/apache/pulsar/pull/12401 I think we should not introduce breaking changes, at least between the same major versions. In addition, I think this approach doesn't *deprecate* a feature but removes a feature. Users can't disable `aggregatePublisherStatsByProducerName` from config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
