kandersen82 commented on code in PR #109:
URL: https://github.com/apache/pulsar-dotpulsar/pull/109#discussion_r1015879948
##########
src/DotPulsar/Internal/Abstractions/IProducerChannel.cs:
##########
@@ -22,6 +22,8 @@ namespace DotPulsar.Internal.Abstractions;
public interface IProducerChannel : IAsyncDisposable
{
- Task<CommandSendReceipt> Send(MessageMetadata metadata,
ReadOnlySequence<byte> payload, CancellationToken cancellationToken);
+ // TODO: Why does one return ValueTask and the other Task?
Review Comment:
I decided to simply remove this todo since I did not change the file after
all (it is outdated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
